input: subscribe to tablet tool events from cursor #2060
21
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to the raw tablet events, the cursor events transform the coordinates based on a mapped output orientation. Otherwise those events are the same.
|
@dashavoo This should solve your issue, would be nice if you could confirm. |
jp7677
force-pushed
the
tablet-auto-rotation
branch
from
363e25f
to
58140b8
Compare
This makes the behavior consistent with auto-rotation as a result of output mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to the raw tablet events, the cursor events transform the coordinates based on a mapped output orientation. Otherwise those events are the same. See https://gitlab.freedesktop.org/wlroots/wlroots/-/blob/master/types/wlr_cursor.c#L897
Note that this only applies to absolute coordinates, the relative ones (
dx,dy) are not transformed, in that case a user still has to manually set rotation in our tablet config.Additionally our own rotation is applied after area transformation, but the auto rotation is applied before. No real issue, just a slightly inconsistent behavior. We could turn around our behavior though to make this fully consistent, which is a minimal change.TODO:
Closes #1990
cc: @dashavoo