Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This turned out to be a bit more complex because the
wlr_renderer_init_wl_display()
call we used to do does not store or return thewlr_linux_dmabuf_v1
pointer anywhere (which we need to supply towlr_scene_set_linux_dmabuf_v1()
).So instead of using
wlr_renderer_init_wl_display()
we just do it manually. This is also what the the sway scene graph patches do. We could also just use both but that causes duplicated globals warnings in wlroots which might cause further hard to detect / debug issues.As for how to actually test this.. I have no idea.
Todo: