Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: harmonise lint configuration #1688

Merged
merged 5 commits into from
Nov 16, 2023
Merged

chore: harmonise lint configuration #1688

merged 5 commits into from
Nov 16, 2023

Conversation

0fatal
Copy link
Contributor

@0fatal 0fatal commented Nov 15, 2023 •
edited
Loading

  1. refactor and reuse eslint configurations
    • now we have out-of-the-box formatting capabilities in all sub projects
    • there is only one dependency for eslint, prettier and related configurations now
  2. readd husky for linting only changed codes
  3. add editorconfig for consistent editing format
  4. add stylelint for format css/scss
  5. lint all codes

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 15, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@maslow maslow merged commit fcab606 into labring:main Nov 16, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maslow maslow maslow approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0fatal @maslow