add eb.jsonPath<$>.
#791
Merged
add eb.jsonPath<$>.
#791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
added
enhancement
koskimas
approved these changes
Dec 29, 2023
thecodrr
pushed a commit
to thecodrr/kysely
that referenced
this pull request
Sep 3, 2024
* extend json path builder to hold a JSONPathNode. * add eb.jsonPath. * eb.jsonPath tests. * no runtime arg. this is just type-level arg. * brand the generic as `$`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #790.
This PR exposes the
JSONPathBuilderfrom #440, for type-safe building of standalone JSON paths (just the$.key[at]strings). These are required in some JSON functions, e.g.json_set(MySQL/SQLite).The generic dictates the
$root document type - not providing it returns aKyselyTypeError. This aligns with WYSIWYG since it is not part of the generated SQL. The alternative was requesting a runtime argument - it just felt awkward.The generated SQL:
'$.key[0]'