Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add addIndex & dropIndex @ AlterTableBuilder #720

Merged
merged 15 commits into from
Nov 21, 2023
Merged

add addIndex & dropIndex @ AlterTableBuilder #720

merged 15 commits into from
Nov 21, 2023

Conversation

Gaspero
Copy link
Contributor

@Gaspero Gaspero commented Oct 2, 2023

closes #507
closes #508

@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 9:48am

@igalklebanov igalklebanov added enhancement New feature or request api Related to library's API labels Nov 7, 2023
@igalklebanov igalklebanov added the mysql Related to MySQL label Nov 7, 2023
igalklebanov
igalklebanov previously requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

Looks good! 💪

Missing some jsdocs..

src/schema/alter-table-builder.ts Show resolved Hide resolved
src/schema/alter-table-builder.ts Show resolved Hide resolved
@igalklebanov igalklebanov dismissed their stale review November 7, 2023 11:38

might have made a mistake.

@igalklebanov igalklebanov merged commit 4748fbe into kysely-org:master Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov left review comments

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request mysql Related to MySQL
Projects
None yet
Milestone
No milestone
2 participants
@Gaspero @igalklebanov