Workaround obscure RDS Data Api Bug #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
requested changes
May 10, 2023
igalklebanov
added
postgres
So I know this isn't ideal because it's making changes in kysely core for a 3rd party adapter - however it is also the simplest fix There's some bug in the RDS api that does not like `in` statements used with char fields - it's interpreting the in values as strings instead of chars and failing Switching it to an orWhere statement fixes the problem Wanted to throw this up here in case you were willing to accept this change - otherwise we'll have to copy the whole PostgresIntrospector into kysely-data-api to make this one change
Co-authored-by: Igal Klebanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I know this isn't ideal because it's making changes in kysely core for a 3rd party adapter - however it is also the simplest fix
There's some bug in the RDS api that does not like
instatements used with char fields - it's interpreting the in values as strings instead of chars and failingSwitching it to an orWhere statement fixes the problem
Wanted to throw this up here in case you were willing to accept this change - otherwise we'll have to copy the whole PostgresIntrospector into kysely-data-api to make this one change