Create a proper package #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyan001
reviewed
Jul 22, 2021
kyan001
reviewed
Jul 22, 2021
While "_main" may be widely used for this, it's also somewhat unintuitive.
kyan001
reviewed
Jul 22, 2021
| @@ -30,3 30,6 @@ def main(assigned_args: list = None): | |||
|
|
|||
| for addr in args.dest_addr: | |||
| ping3.verbose_ping(addr, count=args.count, ttl=args.ttl, timeout=args.timeout, size=args.size, interval=args.interval, interface=args.interface) | |||
|
|
|||
| if __name__ == "__main__": | |||
There was a problem hiding this comment.
We suppose to use python3 -m ping3.command_line ... to run this line, right?
Should we need a __main__.py which has the following content?
from . import command_line
if __name__ == "__main__":
command_line.main()So that we can use python3 -m ping3 ... to run in command line.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four top-level modules, two of them with generic names, is bad.
Closes #38.