Feat: Install submariner as fleet plugin #660
Conversation
✅ Deploy Preview for kurator-dev canceled.
|
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
138829f
to
e8d5d57
Compare
Flying-Tom
force-pushed
the
submariner-plugin
branch
2 times, most recently
from
edc1959
to
15a499c
Compare
|
/kind api-change |
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
117648a
to
14b3f04
Compare
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
f6e04d1
to
14b3f04
Compare
kurator-bot
added
size/XXL
do-not-merge/contains-merge-commits
and removed
size/L
labels
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
fd7746c
to
a747645
Compare
kurator-bot
added
do-not-merge/contains-merge-commits
size/XL
and removed
do-not-merge/contains-merge-commits
size/XXL
labels
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
5df69b9
to
a747645
Compare
kurator-bot
added
size/XXL
and removed
do-not-merge/contains-merge-commits
size/XL
labels
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
a4802b6
to
a4b3db4
Compare
Flying-Tom
changed the title
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
d319fd5
to
0db2011
Compare
Flying-Tom
force-pushed
the
submariner-plugin
branch
2 times, most recently
from
d099e13
to
d2137cb
Compare
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
d2137cb
to
0b207ab
Compare
Signed-off-by: Tom <[email protected]>
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
0b207ab
to
852a77c
Compare
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
67b6623
to
f082e40
Compare
Signed-off-by: Tom <[email protected]>
Flying-Tom
force-pushed
the
submariner-plugin
branch
from
f082e40
to
aad9563
Compare
| RookClusterComponentName = "rook-ceph" | ||
| FlaggerComponentName = "flagger" | ||
| TestloaderComponentName = "testloader" | ||
| SubMarinerBrokerComponentName = "sm-broker" |
There was a problem hiding this comment.
please use the full name(submariner) if there's no particular reason
There was a problem hiding this comment.
This abbr is due to the fact that helm has a limit on name of release (mentioned in Helm#6006). I will try to revalidate if full name will cause the too long name excepetion.
There was a problem hiding this comment.
To be more specific, when SubMarinerBrokerComponentName is "submariner-broker", broker cannot be installed because helm-controller reconciliation failed: Helm install failed: release name "submariner-k8s-broker-submariner-broker-kurator-member1
| FlaggerComponentName = "flagger" | ||
| TestloaderComponentName = "testloader" | ||
| SubMarinerBrokerComponentName = "sm-broker" | ||
| SubMarinerOperatorComponentName = "sm-operator" |
There was a problem hiding this comment.
Although I can change the targetNamespace to be shorter (i.e. , submariner), the namespace in operator fixed at [submariner-operator](https://github.com/submariner-io/submariner-charts/blob/cdd86cf19f1f6fc1c6791c51d1e2bf09c479ee36/submariner-operator/templates/submariner.yaml#L5), and submariner-operator-submariner-operator-kurator-member1` is also too long.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Will defer to @LiZhenCheng9527 |
|
/lgtm |
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
A PR to track the feat of submariner fleet plugin implementation
Which issue(s) this PR fixes:
Fixes #657