-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Install submariner as fleet plugin #660
Conversation
✅ Deploy Preview for kurator-dev canceled.
|
138829f
to
e8d5d57
Compare
edc1959
to
15a499c
Compare
/kind api-change |
117648a
to
14b3f04
Compare
f6e04d1
to
14b3f04
Compare
fd7746c
to
a747645
Compare
5df69b9
to
a747645
Compare
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
a4802b6
to
a4b3db4
Compare
d319fd5
to
0db2011
Compare
d099e13
to
d2137cb
Compare
d2137cb
to
0b207ab
Compare
Signed-off-by: Tom <[email protected]>
0b207ab
to
852a77c
Compare
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
67b6623
to
f082e40
Compare
Signed-off-by: Tom <[email protected]>
f082e40
to
aad9563
Compare
RookClusterComponentName = "rook-ceph" | ||
FlaggerComponentName = "flagger" | ||
TestloaderComponentName = "testloader" | ||
SubMarinerBrokerComponentName = "sm-broker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the full name(submariner) if there's no particular reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This abbr is due to the fact that helm has a limit on name of release (mentioned in Helm#6006). I will try to revalidate if full name will cause the too long name excepetion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more specific, when SubMarinerBrokerComponentName
is "submariner-broker", broker cannot be installed because helm-controller reconciliation failed: Helm install failed: release name "submariner-k8s-broker-submariner-broker-kurator-member1
FlaggerComponentName = "flagger" | ||
TestloaderComponentName = "testloader" | ||
SubMarinerBrokerComponentName = "sm-broker" | ||
SubMarinerOperatorComponentName = "sm-operator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I can change the targetNamespace to be shorter (i.e. , submariner), the namespace in operator fixed at [
submariner-operator](https://github.com/submariner-io/submariner-charts/blob/cdd86cf19f1f6fc1c6791c51d1e2bf09c479ee36/submariner-operator/templates/submariner.yaml#L5)
, and submariner-operator-submariner-operator-kurator-member1` is also too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gerneral LGTM with small nits
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will defer to @LiZhenCheng9527 |
/lgtm |
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
A PR to track the feat of submariner fleet plugin implementation
Which issue(s) this PR fixes:
Fixes #657