proposal:Single cluster deployment application #654
Conversation
Signed-off-by: yeyeye2333 <[email protected]>
|
Welcome @yeyeye2333! It looks like this is your first PR to kurator-dev/kurator 🎉 |
✅ Deploy Preview for kurator-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/proposals/application/single_cluster_deployment_application.md
Outdated
Show resolved
Hide resolved
| ```go | ||
| // ApplicationDestination defines the configuration to dispatch an artifact to a fleet or specific clusters. | ||
| // Fleet and cluster are mutually exclusive. | ||
| type ApplicationDestination struct { |
There was a problem hiding this comment.
change fleet-manager API or cluster-operator API ?
There was a problem hiding this comment.
The application is currently under fleet-manager, and I want to put it under cluster-operator
There was a problem hiding this comment.
application as a feature that depends on fleet, why put it in cluster-operator？
Even if you don't rely on fleet in a single cluster, fleet is still needed in a multi-cluster environment
There was a problem hiding this comment.
Deployment of application in single cluster without Fleet, does it mean that Fleet Manager does not need to be installed? So I need to register the application in cluster-operator. Will registering the application in cluster-operator affect fleet's use of the application?
There was a problem hiding this comment.
No.
Deployment of application in single cluster without Fleet, means not need to create fleet.
Rather than do not install fleet manager.
…tion.md Signed-off-by: yeyeye2333 <[email protected]>
|
/lgtm |
|
@hzxuzhonghu This PR is Ready to Merge |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Modify the application API to allow setting the application's destination to a cluster, reducing the operational steps required for Kurator in a single-cluster environment and increasing Kurator's flexibility.
Which issue(s) this PR fixes:
a part of #653
Does this PR introduce a user-facing change?: