Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to gamesdata.json for thumbnail rendering #5121

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

sweta-singh28
Copy link
Contributor

@sweta-singh28 sweta-singh28 commented Aug 7, 2024

PR Description πŸ“œ

Updated the gamesData.json file to ensure that the Pig Game and Tiny Fishing game images render correctly.
Fixes #4887


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have specified the respective issue number for which I have requested the new game.

Pig Game
Screenshot 2024-08-07 180733

Tiny Fishing game
tinyfishing



Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented Aug 7, 2024

Thank you @sweta-singh28 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

@sweta-singh28 sweta-singh28 changed the title changes Changes to gamesdata.json for thumbnail rendering Aug 7, 2024
@ishita-43 ishita-43 added Ready to merge πŸ₯³ gssoc GSSoC24 program label labels Aug 8, 2024
@kunjgit kunjgit merged commit 737d930 into kunjgit:main Aug 8, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented Aug 8, 2024

Thank you @sweta-singh28 , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The thumbnail for the Tiny fishing game and Pig game isn't rendering correctly.
3 participants