Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cow Bull Game #5020

Merged
merged 12 commits into from
Aug 8, 2024
Merged

Cow Bull Game #5020

merged 12 commits into from
Aug 8, 2024

Conversation

mukilan2815
Copy link
Contributor

PR Description 📜

Fixes #4799

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

image


Thank you soo much for contributing to our repository 💗

mukilan2815 added 3 commits July 14, 2024 12:36
d
7156322
feat: Add CowBull game to GameZone
7f15a81 
The CowBull game has been added to the GameZone repository. This commit includes the necessary files and updates to the README.md file.
Merge branch 'main' of https://github.com/mukilan2815/GameZone
a182eea
@kunjgit
Copy link
Owner

kunjgit commented Jul 29, 2024

Thank you @mukilan2815 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@mukilan2815 mukilan2815 mentioned this pull request Jul 29, 2024
Closed
10 tasks
@mukilan2815
Copy link
Contributor Author

@ishita-43 please check it

ishita-43
ishita-43 reviewed Jul 30, 2024
View reviewed changes
README.md Show resolved Hide resolved
ishita-43
ishita-43 requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make following changes

@mukilan2815
Copy link
Contributor Author

you can check now
@ishita-43

@ishita-43
Copy link
Collaborator

you can check now @ishita-43

Resolve the merge conflicts of readme. Md file

@mukilan2815
Copy link
Contributor Author

@ishita-43 check it now

@ishita-43
Copy link
Collaborator

@ishita-43 check it now

Again resolve them

@mukilan2815
Copy link
Contributor Author

@ishita-43 check now

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 31, 2024
@mukilan2815
Copy link
Contributor Author

Merge? @ishita-43 GSSOC gonna finsih

@ishita-43
Copy link
Collaborator

Merge? @ishita-43 GSSOC gonna finsih

Will be done by the admin

@ishita-43
Copy link
Collaborator

And also I think contribution is extended till aug 10

@mukilan2815
Copy link
Contributor Author

Oh okok tq

@mukilan2815
Copy link
Contributor Author

@ishita-43 merge?

@ishita-43
Copy link
Collaborator

@ishita-43 merge?

Will be done by the admin

@ishita-43
Copy link
Collaborator

Pleaseee resolve merge conflicts again

@mukilan2815
Copy link
Contributor Author

@ishita-43 please make it soon merge it

@ishita-43
Copy link
Collaborator

Admin will do this task may be within 1-2 days

@kunjgit
Copy link
Owner

kunjgit commented Aug 8, 2024

@mukilan2815 resolve the merge conflicts ! ⌛

@mukilan2815
Copy link
Contributor Author

@kunjgit check now

@kunjgit kunjgit merged commit 0a18ed7 into kunjgit:main Aug 8, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 8, 2024

Thank you @mukilan2815 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees

@mukilan2815 mukilan2815

Labels
gssoc GSSoC24 program label level3 Adding new features Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Cow Hunting
3 participants
@mukilan2815 @kunjgit @ishita-43