Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bounce ball game #4220

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Added bounce ball game #4220

merged 9 commits into from
Aug 8, 2024

Conversation

YadlaMani
Copy link
Contributor

@YadlaMani YadlaMani commented Jun 4, 2024 •
edited
Loading

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #4218

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 4, 2024

Thank you @YadlaMani ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

kunjgit
kunjgit requested changes Jun 4, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @YadlaMani,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@YadlaMani
Copy link
Contributor Author

@kunjgit fixed the readme with the changes you requested

kunjgit
kunjgit requested changes Jun 4, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @YadlaMani,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@YadlaMani
Copy link
Contributor Author

@kunjgit done the requested changes

kunjgit
kunjgit requested changes Jun 4, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @YadlaMani,
You need to make the following changes:

  • Please modify the main README.md file.

Hoping that you will make those changes soon 🚀

@YadlaMani
Copy link
Contributor Author

@kunjgit yeah done the changes

ishita-43
ishita-43 requested changes Jun 25, 2024
View reviewed changes
assets/images/Screenshot 2024-06-04 224119.png Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ishita-43
ishita-43 approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jul 27, 2024
@kunjgit kunjgit merged commit 654ae3c into kunjgit:main Aug 8, 2024
@kunjgit
Copy link
Owner

kunjgit commented Aug 8, 2024

Thank you @YadlaMani , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunjgit kunjgit kunjgit requested changes

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
Changes Requested ⚒️ Changes have to be done gssoc GSSoC24 program label level3 Adding new features Pending ⏱️ Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Adding a bouncing ball game
3 participants
@YadlaMani @kunjgit @ishita-43