Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMIController: Remove Expectations from VMI controller #12795

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Barakmor1
Copy link
Member

@Barakmor1 Barakmor1 commented Sep 11, 2024

Remove the Expectations usage from VMI controller. It was used to prevent multiple launcher pods from being created when informers weren't synced, but this can be handled more simply with a List API call.
The Expectations code, copied from Kubernetes, is outdated and couple us to another project.
Removing it's use from the VMI Controller will simplify and clarify KubeVirt codebase.

What this PR does

Before this PR:

After this PR:

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stu-gott for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Remove the Expectations usage from the VMI controller.
It was used to prevent multiple launcher pods from being
created when informers weren't synced, but this can be
handled more simply with a List API call.
The Expectations package, copied from Kubernetes in 2016,
is complex and outdated.
Removing it will simplify and clarify the KubeVirt codebase.

Signed-off-by: bmordeha <[email protected]>
@Barakmor1 Barakmor1 marked this pull request as draft September 11, 2024 11:41
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
@Barakmor1
Copy link
Member Author

/sig code-quality

@Barakmor1 Barakmor1 marked this pull request as ready for review September 11, 2024 11:43
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2024
@Barakmor1
Copy link
Member Author

/cc @xpivarc

@kubevirt-bot
Copy link
Contributor

@Barakmor1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.31-sig-compute f159d42 link true /test pull-kubevirt-e2e-k8s-1.31-sig-compute
pull-kubevirt-e2e-arm64 f159d42 link false /test pull-kubevirt-e2e-arm64
pull-kubevirt-e2e-k8s-1.31-sig-storage f159d42 link true /test pull-kubevirt-e2e-k8s-1.31-sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. sig/code-quality sig/virtualization size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants