cleanup(virtctl): More robust VM decoding and minor cleanups in create vm unit and func tests #12794
428
−598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup the virtctl create preference unit tests by: - Reorganizing tests - Removing redundant table entry arguments Signed-off-by: Felix Matouschek <[email protected]>
Cleanup the virtctl create instancetype unit tests by: - Reorganizing tests - Adding missing test cases - Removing redundant table entry arguments Signed-off-by: Felix Matouschek <[email protected]>
Export the ValidatePreferenceSpec func to be consistent with instancetype-admitter.go and to allow use of the validation logic in other places. Signed-off-by: Felix Matouschek <[email protected]>
Valdidate the specs of created instancetypes and preferences by calling ValidateInstanceTypeSpec and ValidatePreferenceSpec, which are also used by the validating admitters. Signed-off-by: Felix Matouschek <[email protected]>
…ests Drop the functional tests of virtctl create instancetype and virtctl create preference because all tests cases are already covered by the unit tests of the commands. The functional tests do not provide any additional value. Signed-off-by: Felix Matouschek <[email protected]>
Make VM decoding a little more robust by using runtime.Decode and apply some minor cleanups throughout the test file. Signed-off-by: Felix Matouschek <[email protected]>
Make VM decoding a little more robust by using runtime.Decode and apply some minor cleanups throughout the test file. Use the instancetype and preference builders to construct resources and drop the no longer required workaround in createVMWithRWOVolume. Also use testsuite.GetTestNamespace(nil) where appropriate. Signed-off-by: Felix Matouschek <[email protected]>
kubevirt-bot
added
release-note-none
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Merge after #12754 |
kubevirt-bot
added
the
do-not-merge/hold
kubevirt-bot
requested review from
akrejcir,
jean-edouard,
kbidarkar,
oshoval and
victortoso
|
@0xFelix: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/sig code-quality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Make VM decoding a little more robust by using runtime.Decode and apply
some minor cleanups throughout the test files.
In the func tests use the instancetype and preference builders to
construct resources and drop the no longer required workaround in
createVMWithRWOVolume. Also use testsuite.GetTestNamespace(nil) where
appropriate.
Before this PR:
After this PR:
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Merge after #12754
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note