Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] fix: correctly check dry-run requests #12749

Open
wants to merge 1 commit into
base: release-1.1
Choose a base branch
from
Open

[release-1.1] fix: correctly check dry-run requests #12749

wants to merge 1 commit into from

Conversation

acardace
Copy link
Member

@acardace acardace commented Sep 6, 2024

Manual backport of #12696.

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

@acardace
fix: correctly check dry-run requests
32cc692 
In the pod eviction admitter some dry run requests were not caught
due to KubeVirt only checking the dry-run field in the admission review
but not in the object contained in the admission review.

This was causing dry run requests made through kubectl drain using the
'--dry-run=server' flag to be processed as non dry-run requests.

It's possible that this is Kubernetes bug but it should be anyway fixed
fixed in the meantime.

Signed-off-by: Antonio Cardace <[email protected]>
(cherry picked from commit 6bdf136)
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 6, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from acardace. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acardace acardace changed the title fix: correctly check dry-run requests [release-1.1] fix: correctly check dry-run requests Sep 6, 2024
@dosubot dosubot bot added kind/bug sig/api Denotes an issue or PR that relates to changes in api. labels Sep 6, 2024
@kubevirt-bot
Copy link
Contributor

@acardace: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-k8s-1.28-sig-network 32cc692 link true /test pull-kubevirt-e2e-k8s-1.28-sig-network-1.1
pull-kubevirt-e2e-arm64 32cc692 link false /test pull-kubevirt-e2e-arm64-1.1
pull-kubevirt-e2e-kind-1.27-sriov 32cc692 link true /test pull-kubevirt-e2e-kind-1.27-sriov-1.1
pull-kubevirt-e2e-k8s-1.28-sig-compute 32cc692 link true /test pull-kubevirt-e2e-k8s-1.28-sig-compute-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stu-gott stu-gott Awaiting requested review from stu-gott

@xpivarc xpivarc Awaiting requested review from xpivarc

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug release-note-none Denotes a PR that doesn't merit a release note. sig/api Denotes an issue or PR that relates to changes in api. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acardace @kubevirt-bot