[release-1.2] Move hotplug setups to webhook #12553
Open
274
−481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
kubevirt-bot
added
sig/buildsystem
|
Hi @xpivarc , I think that the test in the last commit should be added to the main branch |
|
/lgtm |
|
@Barakmor1 Thanks for the review. I already opened #12583 for main and 1.3 backport. |
xpivarc
force-pushed
the
release-1.2-defaults-in-webhook
branch
from
2d71cec
to
9501f22
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest-required |
kubevirt-bot
added
the
needs-rebase
Previously all VMI mutation tests were applying presets to the VMI. This change moves these specific preset tests into their own context to avoid polluting other tests. Signed-off-by: Lee Yarwood <[email protected]> (cherry picked from commit 0431cfd) Signed-off-by: Luboslav Pivarc <[email protected]>
This change moves defaulting of CurrentCPUTopology in the VMI from the VM controller into the VMI mutation webhook. This defaulting would happen prior to instance types and preferences being applied to the VMI and would thus capture in the incorrect state of the VMI when instance types and preferences are used. The following changes in this series require this in order to introduce support instance types and preferences with LiveUpdate. This also fixes bug kubevirt#11251 where CurrentCPUTopology is not updated to reflect a new instance type being used in clusters where LiveUpdate is not currently enabled. Signed-off-by: Lee Yarwood <[email protected]> (cherry picked from commit 01a3725) Signed-off-by: Luboslav Pivarc <[email protected]>
As with the previous change this change moves setup logic for hotplug into the VMI mutation webhook in order to allow for instance type and preference support of LiveUpdate. By moving this logic into the mutation webhook we can now provide MaxSockets and MaxGuest as centralised instance type attributes that are applied to the VMI during creation. Signed-off-by: Lee Yarwood <[email protected]> (cherry picked from commit 2f8777b) Signed-off-by: Luboslav Pivarc <[email protected]>
This test catch a regression. Signed-off-by: Luboslav Pivarc <[email protected]>
xpivarc
force-pushed
the
release-1.2-defaults-in-webhook
branch
from
9501f22
to
912e945
Compare
kubevirt-bot
removed
the
needs-rebase
|
/retest |
|
@xpivarc: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test pull-kubevirt-unit-test-1.2 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cc @lyarwood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Moves the hotplug defaulting to webhook in order to properly work with defaulting of cpu topology. Without this path a VM without topology, with request &/ limits would most likely fail to start.
Fixes #
Links to places where the discussion took place:
Special notes for your reviewer
This is 1.2 specific regression. Therefore I skip main.
Release note