Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-adding cloudflare to adopters, and some tidying #11790

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Re-adding cloudflare to adopters, and some tidying #11790

merged 1 commit into from
Apr 27, 2024

Conversation

aburdenthehand
Copy link
Contributor

It looks as though Cloudflare was accidentally dropped from our ADOPTERS file back in 2021 when the file was refactored: https://github.com/kubevirt/kubevirt/pull/6385/files

I've gotten in touch with Terin from Cloudflare and he confirmed that they're still using KubeVirt. This PR re-adds them after a few years of erroneous absence. Tagging @muff1nman for awareness.

In addition, I've enforced the alphabetical order of each adopter type (moving only Genesis cloud, Puzl, and Kasten by Veeam), and added to the note at top of page to give new adopters a bit more guidance.

Release note

Re-adding Cloudflare to our ADOPTERS list

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 25, 2024
@enp0s3
Copy link
Contributor

enp0s3 commented Apr 25, 2024

/approve

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 25, 2024
@aburdenthehand aburdenthehand force-pushed the re-adding_cloudflare_to_adopter branch from 93efbe8 to 6263ec3 Compare April 26, 2024 08:19
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
@aburdenthehand
Copy link
Contributor Author

Rebased after #11785 and have also moved the new NCR Voyix entry to enforce alphabetical order.

@kubevirt-bot
Copy link
Contributor

@muff1nman: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alicefr
Copy link
Member

alicefr commented Apr 26, 2024

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@kubevirt-commenter-bot
Copy link

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-storage
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-operator
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alicefr, enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit d1b963f into kubevirt:main Apr 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muff1nman muff1nman muff1nman approved these changes

@stu-gott stu-gott Awaiting requested review from stu-gott

@vladikr vladikr Awaiting requested review from vladikr

Assignees

@alicefr alicefr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aburdenthehand @enp0s3 @kubevirt-bot @alicefr @kubevirt-commenter-bot @muff1nman