Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rewrite annotation from minikube ingress example #46603

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove rewrite annotation from minikube ingress example #46603

wants to merge 1 commit into from

Conversation

robert-cronin
Copy link
Contributor

@robert-cronin robert-cronin commented May 31, 2024 •
edited
Loading

Solves #46546

/sig docs

Before
After

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2024
@robert-cronin
Copy link
Contributor Author

robert-cronin commented May 31, 2024 •
edited
Loading

Relevant part of the run through:

➜  website git:(improve-dual-stack-docs) ✗ k apply -f content/en/examples/service/networking/example-ingress.yaml
ingress.networking.k8s.io/example-ingress created
➜  website git:(improve-dual-stack-docs) ✗ minikube tunnel &
[1] 2913806
➜  website git:(improve-dual-stack-docs) ✗ .✅  Tunnel successfully started

📌  NOTE: Please do not close this terminal as this process must stay alive for the tunnel to be accessible ...

❗  The service/ingress example-ingress requires privileged ports to be exposed: [80 443]
🔑  sudo permission will be asked for it.
🏃  Starting tunnel for service example-ingress.                                                      curl --resolve "hello-world.example:80:127.0.0.1" -i http://hello-world.examplee
HTTP/1.1 200 OK
Date: Fri, 31 May 2024 09:05:49 GMT
Content-Type: text/plain; charset=utf-8
Content-Length: 60
Connection: keep-alive

Hello, world!
Version: 1.0.0
Hostname: web-56bb54ff6d-nxjkl

@netlify Netlify
Copy link

netlify bot commented May 31, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 62c8bb5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/665991330612ea00096c2dfd
😎 Deploy Preview https://deploy-preview-46603--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mengjiao-liu
Copy link
Member

/sig network

/cc @bowei @thockin

Need tech review from the ingress side.

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 3, 2024
@kundan2707
Copy link
Contributor

tested in terms of functionality and example validty

@kundan2707
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ec62522f992a994744bf71f7999d06a44c720d3

@divya-mohan0209
Copy link
Contributor

@kubernetes/sig-network-pr-reviews : PTAL

@shaneutt
Copy link
Member

/cc @strongjz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@kundan2707 kundan2707

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@robert-cronin @k8s-ci-robot @mengjiao-liu @kundan2707 @divya-mohan0209 @shaneutt