Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hugo build timeout #35773

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Aug 8, 2022

According to https://gohugo.io/getting-started/configuration/#timeout, the timeout value should be a duration (e.g. 100s) or number of milliseconds. Current value of 3000 translates to 3 seconds.

This PR updates the timeout in hope it resolves the netlify preview issues that show up frequently during past weeks.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 8, 2022
According to https://gohugo.io/getting-started/configuration/#timeout,
the timeout value should be a duration (e.g. `100s`) or number of
milliseconds. Current value of 30000 translates to 30 seconds.

This PR updates the timeout in hope it resolves the netlify preview
issues that show up frequently during past weeks.
@netlify
Copy link

netlify bot commented Aug 8, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit 609027b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62f06ab468268b00089f3da8
😎 Deploy Preview https://deploy-preview-35773--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mk46
Copy link
Member

mk46 commented Aug 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 08ac82d5301399262bed824616883bc0e21633e2

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sftim
Copy link
Contributor

sftim commented Aug 8, 2022

Thanks @tengqm

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit fb5f25b into kubernetes:main Aug 8, 2022
@seokho-son
Copy link
Member

Thanks @tengqm :)
If I don't experience #35780 anymore (for a while), I will close the issue as well. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants