Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Translate the glossary term Event into Korean #35502

Merged
merged 1 commit into from
Aug 7, 2022
Merged

[ko] Translate the glossary term Event into Korean #35502

merged 1 commit into from
Aug 7, 2022

Conversation

dewble
Copy link
Contributor

@dewble dewble commented Jul 28, 2022

Signed-off-by: dewble [email protected]

fix #35447

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @dewble!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/ko Issues or PRs related to Korean language labels Jul 28, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 28, 2022
@netlify
Copy link

netlify bot commented Jul 28, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit f59d5d4
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62edd88e11a2a95008fb27db
😎 Deploy Preview https://deploy-preview-35502--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

This PR is WIP. :)
I am sure the contributor will update the PR and review can be initiated once the contributor update WIP contests.

@seokho-son
Copy link
Member

/assign @seokho-son

seokho-son
seokho-son reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요. @dewble
쿠버네티스에 기여를 환영합니다!! :)

아직 완료되지 않은 내용이 있지만, 리뷰를 먼저 진행해보았습니다.
리뷰 의견 참고하셔서, PR 업데이트를 부탁 드립니다.!

content/ko/docs/reference/glossary/event.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/event.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/event.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/event.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/event.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/event.md Outdated Show resolved Hide resolved
@seokho-son
Copy link
Member

@dewble 님~~ :)
조만간 한글화 작업 브랜치의 스위칭(ko.2 -> ko.3)이 진행될 예정입니다.

스위칭 이후에 해당 PR을 처리해도 괜찮지만~
base 브랜치가 변경되면, PR도 rebase 하여 업데이트해야 하므로 다소 번거로울 수 있습니다. ;)

혹시 가능하시면, 리뷰 의견 확인하셔서 PR 업데이트를 부탁 드립니다.

@dewble dewble force-pushed the ko-translate-the-glossary-term-event branch 4 times, most recently from 3ac0355 to 52ee68c Compare August 5, 2022 16:38
@dewble dewble force-pushed the ko-translate-the-glossary-term-event branch from 52ee68c to f59d5d4 Compare August 6, 2022 02:57
@seokho-son
Copy link
Member

Thank you @dewble

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3182eb45c362131ba8df02ac18a19d48a1fe2b84

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 287ef17 into kubernetes:dev-1.24-ko.2 Aug 7, 2022
@jihoon-seo jihoon-seo mentioned this pull request Aug 9, 2022
Closed
@dewble dewble mentioned this pull request Jun 12, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@ianychoi ianychoi Awaiting requested review from ianychoi

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dewble @k8s-ci-robot @seokho-son