Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove initializers (ko) #14653

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Remove initializers (ko) #14653

merged 1 commit into from
Jul 4, 2019

Conversation

mvladev
Copy link
Contributor

@mvladev mvladev commented May 31, 2019

Initializers are removed in 1.14

Related (en) PR #14602.

Remove initializers (ko)
1f8ef38 
Initializers are removed in 1.14 [1]

[1]: kubernetes/kubernetes#72972
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2019
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 31, 2019
@netlify
Copy link

netlify bot commented May 31, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1f8ef38

https://deploy-preview-14653--kubernetes-io-master-staging.netlify.com

@claudiajkang
Copy link
Contributor

@mvladev Thank you for your contribution.

However, the working branch of Korean Localization team is dev-1.14-ko.5.
So, could you change the base branch master to dev-1.14-ko.5 in this PR?

@gochist
Copy link
Member

gochist commented Jun 3, 2019

@mvladev
Thank you for this PR! The upstream PR #14602 is not included in dev-1.14-ko.5, the current downstream development branch. So I think the milestone for this PR will be the next team milestone, dev-1.15-ko.1 and maybe dev-1.14-ko.6. So I'll let you know when those branches are opened.

For your information, Ko l10n team is using shared development branches according to the l10n guide - branching strategy. We do not usually use master as we don't have enough resources to maintain multiple branches at the same time.

@gochist
Copy link
Member

gochist commented Jul 4, 2019

@mvladev Thank you! Korean l10n team discussed about processing the PRs against master branch at the last team online meeting, July 2nd. And we decided to approve those PRs only for the trivial fixes. Sorry for the delay.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9feeb19 into kubernetes:master Jul 4, 2019
joaovitor pushed a commit to joaovitor/website that referenced this pull request Jul 5, 2019
@joaovitor
Remove initializers (ko) (kubernetes#14653)
76da0bc 
Initializers are removed in 1.14 [1]

[1]: kubernetes/kubernetes#72972
@mvladev mvladev deleted the remove-initializers-ko branch September 24, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@gochist gochist Awaiting requested review from gochist

Assignees

@gochist gochist

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvladev @claudiajkang @gochist @k8s-ci-robot