Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: fix RequiredIPVSKernelModulesAvailable warning message #74033

Merged
merged 1 commit into from
Mar 5, 2019
Merged

kubeadm: fix RequiredIPVSKernelModulesAvailable warning message #74033

merged 1 commit into from
Mar 5, 2019

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Feb 13, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

RequiredIPVSKernelModulesAvailable warning confuses users suggesting
that the IPVS proxier will not be used, which is not always the case.

Made the warning message less confusing:

        [WARNING RequiredIPVSKernelModulesAvailable]:
The IPVS proxier may not be used because the following required kernel
modules are not loaded: [ip_vs_rr ip_vs_wrr ip_vs_sh]
or no builtin kernel ipvs support was found: map[ip_vs_wrr:{}
ip_vs_sh:{} nf_conntrack_ipv4:{} ip_vs:{} ip_vs_rr:{}].
However, these modules may be loaded automatically by kube-proxy for you
if they are available on your system.

To verify IPVS support:

   Run "lsmod | grep 'ip_vs\|nf_conntrack'" and verify each of the above
modules are listed.

If they are not listed, you can use the following methods to load them:

1. For each missing module run 'modprobe $modulename' (e.g., 'modprobe
ip_vs', 'modprobe ip_vs_rr', ...)
2. If 'modprobe $modulename' returns an error, you will need to install
the missing module support for your kernel.

Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#975

Special notes for your reviewer: this PR is a proper fix for this issue in my opinion. Feel free to accept it instead of this one.

Does this PR introduce a user-facing change?:

kubeadm: improved RequiredIPVSKernelModulesAvailable warning message

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2019
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 13, 2019
@bart0sh bart0sh force-pushed the PR0060-kubeadm-975-RequiredIPVSKernelModulesAvailable-warning-seems-confusing branch from 6cdd696 to a397218 Compare February 13, 2019 20:14
@bart0sh
Copy link
Contributor Author

bart0sh commented Feb 13, 2019

/cc @neolit123
/cc @timothysc

neolit123
neolit123 reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the message update @bart0sh
i think this is all we can do for now.

added some minor nits.

pkg/util/ipvs/kernelcheck_linux.go Outdated Show resolved Hide resolved
pkg/util/ipvs/kernelcheck_linux.go Outdated Show resolved Hide resolved
pkg/util/ipvs/kernelcheck_linux.go Outdated Show resolved Hide resolved
@neolit123
Copy link
Member

/kind cleanup
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2019
@bart0sh
kubeadm: fix RequiredIPVSKernelModulesAvailable warning message
09a2e49 
RequiredIPVSKernelModulesAvailable warning confuses users suggesting
that the IPVS proxier will not be used, which is not always the case.

Made the warning message less confusing:

        [WARNING RequiredIPVSKernelModulesAvailable]:
The IPVS proxier may not be used because the following required kernel
modules are not loaded: [ip_vs_rr ip_vs_wrr ip_vs_sh]
or no builtin kernel ipvs support was found: map[ip_vs_wrr:{}
ip_vs_sh:{} nf_conntrack_ipv4:{} ip_vs:{} ip_vs_rr:{}].
However, these modules may be loaded automatically by kube-proxy for you
if they are available on your system.

To verify IPVS support:

   Run "lsmod | grep 'ip_vs\|nf_conntrack'" and verify each of the above
modules are listed.

If they are not listed, you can use the following methods to load them:

1. For each missing module run 'modprobe $modulename' (e.g., 'modprobe
ip_vs', 'modprobe ip_vs_rr', ...)
2. If 'modprobe $modulename' returns an error, you will need to install
the missing module support for your kernel.

Fixes: kubernetes/kubeadm#975
@bart0sh bart0sh force-pushed the PR0060-kubeadm-975-RequiredIPVSKernelModulesAvailable-warning-seems-confusing branch from a397218 to 09a2e49 Compare February 13, 2019 20:54
@bart0sh bart0sh mentioned this pull request Feb 13, 2019
Closed
@bart0sh
Copy link
Contributor Author

bart0sh commented Feb 14, 2019

Kindly ping reviewers for lgtm/approval

neolit123
neolit123 reviewed Feb 14, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
after the Dedent fix in util/ipvs. thanks!

up to the IPVS package approvers at this point.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2019
@neolit123
Copy link
Member

/assign m1093782566

yagonobre
yagonobre reviewed Feb 15, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bart0sh
/lgtm

timothysc
timothysc approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: bart0sh, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bart0sh
Copy link
Contributor Author

bart0sh commented Mar 4, 2019

/test pull-kubernetes-e2e-gce

@bart0sh
Copy link
Contributor Author

bart0sh commented Mar 4, 2019

/test pull-kubernetes-integration

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@bart0sh
Copy link
Contributor Author

bart0sh commented Mar 5, 2019

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 43616fc into kubernetes:master Mar 5, 2019
@stewart-yu
Copy link
Contributor

Thanks for your improvement @bart0sh
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yagonobre yagonobre yagonobre left review comments

@neolit123 neolit123 neolit123 left review comments

@timothysc timothysc timothysc approved these changes

@m1093782566 m1093782566 Awaiting requested review from m1093782566

@thockin thockin Awaiting requested review from thockin

Assignees

@timothysc timothysc

@neolit123 neolit123

@m1093782566 m1093782566

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequiredIPVSKernelModulesAvailable warning seems confusing
8 participants
@bart0sh @neolit123 @k8s-ci-robot @fejta-bot @stewart-yu @timothysc @yagonobre @m1093782566