Delete non-existent cloud provider nodes with Ready condition Unknown #72559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Also deletes nodes with Ready condition
Unknown
if the node does not exist in the cloud provider. This was introduced in #70344 because we assumed that deleted nodes report Ready condition asFalse
instead ofUnknown
. This PR changes the logic to delete any node that has a Ready condition that is notTrue
and does not exist in the cloud provider (consistent with what we already had prior to merging #70344).Which issue(s) this PR fixes:
Fixes # #72499
Special notes for your reviewer:
@mtaufen I'm not sure if we should be expecting this condition to be
Unknown
, but I've opened this PR to bring things back to what they were prior to #70344. Let me know if you prefer another solution.Does this PR introduce a user-facing change?:
/assign @mtaufen
/sig cloud-provider node