-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow kube-scheduler to tolerate cluster auth config lookup failure #71755
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
liggitt:tolerate-authn-lookup-failure
Dec 6, 2018
Merged
Allow kube-scheduler to tolerate cluster auth config lookup failure #71755
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
liggitt:tolerate-authn-lookup-failure
Dec 6, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/bug
Categorizes issue or PR as related to a bug.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
area/apiserver
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
and removed
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
labels
Dec 5, 2018
/assign @sttts |
liggitt
force-pushed
the
tolerate-authn-lookup-failure
branch
from
December 5, 2018 19:14
43081b5
to
416e114
Compare
liggitt
added
the
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
label
Dec 5, 2018
k8s-ci-robot
removed
the
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
label
Dec 5, 2018
/retest |
1 similar comment
/retest |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 6, 2018
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Dec 6, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 12, 2018
…5-upstream-release-1.13 Automated cherry pick of #71755: Allow kube-scheduler to tolerate cluster auth config lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
sig/scheduling
Categorizes an issue or PR as relevant to SIG Scheduling.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Which issue(s) this PR fixes:
tolerates #71752
1.12 invocations of the scheduler did not require access to the cluster authentication configmap.
1.13 invocations started requiring it if the scheduler is run with access to an in-cluster client. This PR restores the 1.12 behavior.
Does this PR introduce a user-facing change?: