genericapiserver: cut off certificates api dependency #39947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
added
area/apiserver
kind/cleanup
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
sttts
added
the
release-note
k8s-github-robot
added
the
size/L
|
lgtm, squash bazel. |
sttts
added
the
lgtm
sttts
force-pushed
the
sttts-util-cert-certificates-api-dep
branch
from
e8b5635 to
918868b
Compare
sttts
added
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Jenkins kops AWS e2e failed for commit 918868b. Full PR test history. cc @sttts The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 39947, 39936, 39902, 39859, 39915) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By cutting off pkg/apis/certificates depenedency from pkg/util/certs.