Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #126470: Move APIServingWithRoutine to alpha and disabled by default. #126481

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Automated cherry pick of #126470: Move APIServingWithRoutine to alpha and disabled by default. #126481

merged 1 commit into from
Aug 7, 2024

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Jul 31, 2024 •
edited by liggitt
Loading

Cherry pick of #126470 on release-1.30.

#126470: Move APIServingWithRoutine to alpha and disabled by default.

For details on the cherry pick process, see the cherry pick requests page.

Fixes a regression in default 1.30 configurations. Disabled a previously on-by-default optimization for the API server where each **watch** response used a dedicated goroutine. The `APIServingWithRoutine` feature gate has been demoted from beta to alpha, and is now off by default.

Related issues:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jul 31, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 31, 2024
@k8s-ci-robot k8s-ci-robot requested a review from thockin July 31, 2024 13:59
@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t July 31, 2024 13:59
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 31, 2024
@benluddy
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@benluddy
Copy link
Contributor Author

/cc @deads2k

#126470 (comment)

@k8s-ci-robot k8s-ci-robot requested a review from deads2k July 31, 2024 14:02
@deads2k
Copy link
Contributor

deads2k commented Jul 31, 2024

Prior to merge, let master soak a few days.

@benluddy please update description to link to the issue.

/approve
/cc @jpbetz @liggitt

@k8s-ci-robot k8s-ci-robot requested review from jpbetz and liggitt July 31, 2024 14:17
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@seans3
Copy link
Contributor

seans3 commented Jul 31, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 31, 2024
@liggitt liggitt mentioned this pull request Aug 1, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 5, 2024
@deads2k
Copy link
Contributor

deads2k commented Aug 5, 2024

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: abe216e42cbacacffcc5d1245e6f2fbab710f5f0

@deads2k
Copy link
Contributor

deads2k commented Aug 5, 2024

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 5, 2024
@deads2k
Copy link
Contributor

deads2k commented Aug 5, 2024

/kind bug
/kind regression

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 5, 2024
@deads2k
Copy link
Contributor

deads2k commented Aug 5, 2024

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team August 5, 2024 18:30
@wojtek-t
Copy link
Member

wojtek-t commented Aug 6, 2024

@kubernetes/release-managers - for cherrypick approval

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, deads2k, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d0c02cd into kubernetes:release-1.30 Aug 7, 2024
16 checks passed
@Adarsh-verma-14 Adarsh-verma-14 mentioned this pull request Sep 6, 2024
Closed
@linxiulei linxiulei mentioned this pull request Sep 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@thockin thockin Awaiting requested review from thockin

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@deads2k deads2k Awaiting requested review from deads2k

@jpbetz jpbetz Awaiting requested review from jpbetz

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
6 participants
@benluddy @deads2k @seans3 @k8s-ci-robot @wojtek-t @saschagrunert