Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement QueueingHint in TaintToleration #124287

Merged
merged 1 commit into from
May 1, 2024
Merged

implement QueueingHint in TaintToleration #124287

merged 1 commit into from
May 1, 2024

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Apr 12, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR implements QHint for TaintToleration
Taking over #119397

Which issue(s) this PR fixes:

Part of #118893

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The scheduler implements QueueingHint in TaintToleration plugin, which enhances the throughput of scheduling.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2024
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.30 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.30.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Apr 12 07:49:42 UTC 2024.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 12, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 12, 2024
@sanposhiho
Copy link
Member Author

/hold
in order to go thru two reviews.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
sanposhiho
sanposhiho commented Apr 12, 2024
View reviewed changes
pkg/scheduler/framework/plugins/tainttoleration/taint_toleration.go Outdated
@@ -56,10 58,35 @@ func (pl *TaintToleration) Name() string {
// failed by this plugin schedulable.
func (pl *TaintToleration) EventsToRegister() []framework.ClusterEventWithHint {
return []framework.ClusterEventWithHint{
{Event: framework.ClusterEvent{Resource: framework.Node, ActionType: framework.Add | framework.Update}},
{Event: framework.ClusterEvent{Resource: framework.Node, ActionType: framework.Add | framework.UpdateNodeTaint}, QueueingHintFn: pl.isSchedulableAfterNodeChange},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be OK to change it to UpdateNodeTaint based on the discussion in -
#122292

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PreCheck includes not only taint validation, also like node affinity etc., so is this enough? For example, a new added node was rejected by nodeAffinity, but then updated the node label.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under this case, maybe it's taint tolerated before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're actually right; if we want to cover all Nodes that possibly filtered out by preCheck previously, we have to keep Node/Update and actually add Pod/Delete (for node port).

But, from the discussion in https://github.com/kubernetes/kubernetes/pull/122292/files#r1495008072 and then we only added NodeTaint after all, I understand we agree to ignore those cases because they're very minor scenarios, and more importantly, that'd be a big degradation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can apply the same argument. In the other PR, Node label updates have always been ignored.

In this case, we could be introducing a regression.

Let's keep Update until we finish migrating all the preChecks.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AxeZhan
Copy link
Member

AxeZhan commented Apr 16, 2024

/lgtm :)

@sanposhiho
Copy link
Member Author

@kubernetes/sig-scheduling-approvers Can anyone take a look 🙏

@alculquicondor
Copy link
Member

#118893 (comment)

alculquicondor
alculquicondor reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hint itself LGTM

pkg/scheduler/framework/plugins/tainttoleration/taint_toleration.go Outdated
@@ -56,10 58,35 @@ func (pl *TaintToleration) Name() string {
// failed by this plugin schedulable.
func (pl *TaintToleration) EventsToRegister() []framework.ClusterEventWithHint {
return []framework.ClusterEventWithHint{
{Event: framework.ClusterEvent{Resource: framework.Node, ActionType: framework.Add | framework.Update}},
{Event: framework.ClusterEvent{Resource: framework.Node, ActionType: framework.Add | framework.UpdateNodeTaint}, QueueingHintFn: pl.isSchedulableAfterNodeChange},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can apply the same argument. In the other PR, Node label updates have always been ignored.

In this case, we could be introducing a regression.

Let's keep Update until we finish migrating all the preChecks.

pkg/scheduler/framework/plugins/tainttoleration/taint_toleration.go Outdated Show resolved Hide resolved
@sanposhiho
Copy link
Member Author

@kerthcet @alculquicondor Fixed two points from your reviews.

@sanposhiho sanposhiho closed this Apr 29, 2024
@sanposhiho sanposhiho reopened this Apr 29, 2024
@sanposhiho
Copy link
Member Author

sanposhiho commented Apr 29, 2024 •
edited
Loading

(closed once by mistake😓 )

@sanposhiho
Copy link
Member Author

/retest

alculquicondor
alculquicondor reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good example of a simple hint :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8f7b401631a0ebafd6d0a3ed8c9df7ed09fb773c

@sanposhiho
Copy link
Member Author

got two reviews (Aldo, AxeZhan)

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit b276088 into kubernetes:master May 1, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 1, 2024
@sanposhiho sanposhiho mentioned this pull request May 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@sanposhiho @k8s-ci-robot @AxeZhan @alculquicondor @kerthcet @wackxu