Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate v1alpha1 AuthenticationConfiguration to v1beta1 #123696

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Duplicate v1alpha1 AuthenticationConfiguration to v1beta1 #123696

merged 1 commit into from
Mar 6, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Mar 5, 2024 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Adds apiserver.config.k8s.io/v1beta1 AuthenticationConfiguration types

part of kubernetes/enhancements#3331

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-apiserver: the AuthenticationConfiguration type accepted in `--authentication-config` files has been promoted to `apiserver.config.k8s.io/v1beta1`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3331-structured-authentication-configuration

/sig auth
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 5, 2024
@k8s-ci-robot k8s-ci-robot requested review from saad-ali and sttts March 5, 2024 07:41
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 5, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@enj enj mentioned this pull request Mar 5, 2024
Merged
5 tasks
@enj
Copy link
Member

enj commented Mar 5, 2024

Opened #123719 to promote the feature gate.

@enj
Copy link
Member

enj commented Mar 5, 2024

@aramase probably good to make the same change as #123721 for the beta struct.

@aramase aramase force-pushed the aramase/f/kep_3331_v1beta1_api branch from d7704a0 to b502aa6 Compare March 5, 2024 17:10
@aramase
Copy link
Member Author

aramase commented Mar 5, 2024

/assign enj liggitt

@liggitt liggitt added this to the v1.30 milestone Mar 5, 2024
liggitt
liggitt reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

staging/src/k8s.io/apiserver/pkg/apis/apiserver/v1beta1/types.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff --width=250 --side-by-side staging/src/k8s.io/apiserver/pkg/apis/apiserver/{v1alpha1,v1beta1}/types.go shows these are identical to the v1alpha1 types

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified there were no v1alpha1 manual defaults or conversions that needed copying over

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4099985fd10d3e875df9bce9068146e3fd49ad4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 05cb0a5 into kubernetes:master Mar 6, 2024
15 checks passed
@aramase aramase deleted the aramase/f/kep_3331_v1beta1_api branch March 6, 2024 23:38
@enj enj mentioned this pull request Mar 11, 2024
Open
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.30
SIG Auth
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
5 participants
@aramase @k8s-triage-robot @enj @k8s-ci-robot @liggitt