Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate v1alpha1 AuthorizationConfiguration to v1beta1 #123640

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Duplicate v1alpha1 AuthorizationConfiguration to v1beta1 #123640

merged 1 commit into from
Mar 2, 2024

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 2, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds apiserver.config.k8s.io/v1beta1 AuthorizationConfiguration types

Part of kubernetes/enhancements#3221

Does this PR introduce a user-facing change?

kube-apiserver: the AuthorizationConfiguration type accepted in `--authorization-config` files has been promoted to `apiserver.config.k8s.io/v1beta1`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://kep.k8s.io/3221

/sig auth
/milestone v1.30
/assign @palnabarun @ritazh

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 2, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 2, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 2, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 2, 2024
@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2024

/assign @enj

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2024
@k8s-ci-robot k8s-ci-robot added area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 2, 2024
@liggitt liggitt mentioned this pull request Mar 2, 2024
Open
29 tasks
@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2024

/hold for #123639

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2024
@liggitt liggitt mentioned this pull request Mar 2, 2024
Merged
4 tasks
@palnabarun
Copy link
Member

/test pull-kubernetes-node-e2e-containerd

palnabarun
palnabarun approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b6f8c33e0cd44d5125e0decfa77b6d9ff0d730c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2024

/retest

@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2024

/hold cancel

this is orthogonal to the metrics addition

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2024

Hmm, unrelated conformance test error, which is concerning
/retest

@k8s-ci-robot k8s-ci-robot merged commit 8674282 into kubernetes:master Mar 2, 2024
15 checks passed
@liggitt liggitt deleted the authz-beta-config branch July 21, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun palnabarun approved these changes

@mwielgus mwielgus Awaiting requested review from mwielgus

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@ritazh ritazh

@enj enj

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Structured Authz Enhancement
Status: ✅ Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8s-ci-robot @palnabarun @k8s-triage-robot @ritazh @enj