[KEP-3962]Add feature gate for MAP #123425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/apiserver
sig/api-machinery
|
/assign @jpbetz |
|
/approve Should this be combined with the feature PR? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cici37, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Leaving LGTM with @alexzielenski |
|
I think we want to merge this with the rest of the implementation. I"ve added the commit to our WIP implementation branch #123332 |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c21a97060bb92620eadffc5461d93c699d2e4cb6
|
|
@alexzielenski We could merge this PR separately. The API changes is the one need to go with implementation. :) |
jiahuif
suggested changes
Feb 21, 2024
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
tide/merge-method-squash
|
LGTM label has been added. Git tree hash: e81eb71e38d13db450d16f890781c1e6271dcd0e
|
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Jeffwan
pushed a commit
to Jeffwan/kubernetes
that referenced
this pull request
Mar 5, 2024
* Add feature gate for MAP * sort feature gates. --------- Co-authored-by: Jiahui Feng <[email protected]>
Jeffwan
pushed a commit
to Jeffwan/kubernetes
that referenced
this pull request
Mar 6, 2024
* Add feature gate for MAP * sort feature gates. --------- Co-authored-by: Jiahui Feng <[email protected]>
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Mar 28, 2024
* Add feature gate for MAP * sort feature gates. --------- Co-authored-by: Jiahui Feng <[email protected]>
ah8ad3
pushed a commit
to ah8ad3/kubernetes
that referenced
this pull request
Apr 6, 2024
* Add feature gate for MAP * sort feature gates. --------- Co-authored-by: Jiahui Feng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: