Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SELinuxMount feature gate #123157

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Add SELinuxMount feature gate #123157

merged 1 commit into from
Feb 26, 2024

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Feb 6, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

The feature gate enables mounting with -o context=XYZ mount option for all volume types, not only ReadWriteOncePod.

All SELinux label tracking & error reporting infrastructure is already in place from SELinuxMountReadWriteOncePod feature gate. This is just a trivial extension to all access modes.

E2e tests will come as a separate PR.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

New alpha feature gate `SELinuxMount` can be used to speed up SELinux relabeling of volumes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1710-selinux-relabeling

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 6, 2024
@k8s-ci-robot k8s-ci-robot requested review from carlory and dims February 6, 2024 13:44
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@jsafrane jsafrane mentioned this pull request Feb 8, 2024
Closed
@jsafrane
Copy link
Member Author

jsafrane commented Feb 8, 2024

/retest

1 similar comment
@bart0sh
Copy link
Contributor

bart0sh commented Feb 8, 2024

/retest

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 9, 2024
@jsafrane
Copy link
Member Author

jsafrane commented Feb 9, 2024

/retest

Can"t connect to "docker" daemon. please fix and retry

@jsafrane
Copy link
Member Author

jsafrane commented Feb 9, 2024

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 9, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Feb 12, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 12, 2024
@jsafrane
Add SELinuxMount feature gate
d7028a8 
The feature gate enables mounting with -o context=XYZ mount option for all
volume types, not only ReadWriteOncePod.

All SELinux label tracking & error reporting infrastructure is already in
place from SELinuxMountReadWriteOncePod feature gate. This is just a
trivial extension to all access modes.
This was referenced Feb 22, 2024
Merged
Open
@pacoxu
Copy link
Member

pacoxu commented Feb 23, 2024

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-alpha-features

@gnufied
Copy link
Member

gnufied commented Feb 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d9a3f640fe4dddc6dc0c4c28eecff8bf5643d2c

@k8s-ci-robot k8s-ci-robot merged commit c53ac4c into kubernetes:master Feb 26, 2024
20 of 21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@dims dims Awaiting requested review from dims

Assignees

@gnufied gnufied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
5 participants
@jsafrane @k8s-ci-robot @bart0sh @pacoxu @gnufied