Added metric resource name to HPA table #122804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/sig cli |
k8s-ci-robot
added
the
sig/cli
k8s-ci-robot
removed
the
do-not-merge/needs-sig
|
After making the change to the
|
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
|
/remove-kind api-change |
k8s-ci-robot
removed
the
kind/api-change
soltysh
reviewed
Jan 24, 2024
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, sreeram-venkitesh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 89d87ccbdedc4aa6ffdba0be3696993d1ec5d517
|
k8s-ci-robot
added
the
approved
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
leemingeer
pushed a commit
to leemingeer/kubernetes
that referenced
this pull request
Feb 2, 2024
* Added metric resource name to HPA table * Added colon suggested from code review
aramase
pushed a commit
to aramase/kubernetes
that referenced
this pull request
Feb 8, 2024
* Added metric resource name to HPA table * Added colon suggested from code review
dinhxuanvu
pushed a commit
to dinhxuanvu/kubernetes
that referenced
this pull request
Mar 28, 2024
* Added metric resource name to HPA table * Added colon suggested from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind api-change
What this PR does / why we need it:
This PR adds the metric resource name to the table returned when running
kubectl get hpa. TheTARGETSlist currently only prints the currentUtilizationValue and the targetUtilizationValue of the metric, but doesn't specify which metric it is referring to. This PR adds the name of the metric along with this utilization data.Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#1540
Special notes for your reviewer:
Please let me know if there's scope to add more test cases.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: