-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Allow disabling custom-http-errors per ingress #8384
Comments
/good-first-issue |
@strongjz: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hello guys, I would like to work on this issue, can you give me more details on what exactly I need to do? |
/assign |
/unassign |
/assign |
/unassign |
/assign |
@aslafy-z tht annotation is named aptly and does what it is names as. If you are looking for a new feature to handle a case where no existing ingress rule matches a incoming http request and as a result instead of the default-backend of the project handling the response, you want your own behaviour, then I think the documented procedure is to create your own image and use that to create a backend to be configured as a default-backend. Changing an existing annotation that is sort of not named after your desired behaviour does not seem like an improvement. There are several such changes made earlier that has led to unmaintained and unsupportable features and the project is now in a 6 month phase to clean up and stabilize the code. This is my opinion so lets wait for other comments. But I vote for not doing this change you are proposing. I hope the project steers away from such changes that only one user benefits from and that is not deeply thought over and elaborated. But I am not a developer so I could be wrong so lets hope there is enough info posted here about a deep dive analysis on how the change you propose is a improvement for a large number of users. |
Here's my use case, the platform team offers a nginx ingress controller with a company-branded default-backend and handles 500 errors by default. Some apps may want to overwrite this behavior by disabling the company default-backend all-together for their ingress (e.g.: development phases where they want to see their app outputs even if they are errors). I feel like it would be a great addition but I understand your point, let's keep this issue open and see if it gains traction. |
/unassign |
/assign I would like to work on this issue. As I am completely new to this workflow, can I please get some guidance on how to go about working on this issue ? |
There's an open pull request that address this issue. /assign |
When
nginx.ingress.kubernetes.io/custom-http-errors
is set to stringoff
, overwrite the configmap value with an empty list instead of skipping it.My current work-around is to use the
418
HTTP code (nginx.ingress.kubernetes.io/custom-http-errors: "418"
) because my apps aren't using it 😉The text was updated successfully, but these errors were encountered: