Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DaemonSet in kubectl plugin #6155

Open
djkormo opened this issue Sep 11, 2020 · 24 comments
Open

Support for DaemonSet in kubectl plugin #6155

djkormo opened this issue Sep 11, 2020 · 24 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@djkormo
Copy link

djkormo commented Sep 11, 2020

No description provided.

@djkormo djkormo added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 11, 2020
@kundan2707
Copy link
Contributor

@djkormo can you add some description ?

@djkormo
Copy link
Author

djkormo commented Sep 24, 2020

Installing ingress on baremetal with host network

Instead of devployment I decided to use daemonsets

kubectl get pod,ds -n ingress-controller
NAME READY STATUS RESTARTS AGE
pod/ingress-nginx-controller-2zpjj 1/1 Running 0 21d
pod/ingress-nginx-controller-9pwhj 1/1 Running 0 21d
pod/ingress-nginx-controller-jmhfw 1/1 Running 1 21d

NAME DESIRED CURRENT READY UP-TO-DATE AVAILABLE NODE SELECTOR AGE
daemonset.apps/ingress-nginx-controller 3 3 3 3 3 ingress-role=nginx 21d

@skaven81
Copy link

1 for this. At Qualcomm we use Rancher, and Rancher deploys the nginx ingress controller using a DaemonSet. We would very much like to be able to use the kubectl plugin to examine the internal state of the ingress controller.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2020
@skaven81
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2020
@djkormo
Copy link
Author

djkormo commented Dec 28, 2020

/remove-lifecycle stale

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 28, 2021
@elsbrock
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2021
@rikatz
Copy link
Contributor

rikatz commented Apr 29, 2021

Hey,

anyone willing to implement this? Any help would be appreciated

Thanks!

@jacklund
Copy link

jacklund commented Jun 19, 2021

I'm sort of looking at it, although my Go is a little Rusty (sorry for the pun).

As a workaround, however, you can specify the pod-name with --pod pod-name. Since it's a daemonset, all the pods should be configured identically, so you can pick any of them.

E.g. kubectl ingress-nginx backends --pod ingress-nginx-controller-btsx4

Not perfect, but workable.

@iamNoah1
Copy link
Contributor

@djkormo is the solution provided by @jacklund feasible for you?

@djkormo
Copy link
Author

djkormo commented Aug 26, 2021

It's only a workaround not a solution.

@jacklund
Copy link

I've started working on this, I've forked the repository and followed this guide. However, I can't build the plugin because of a couple of issues.

The build/build-plugin.sh script has an extra double-quote here, which prevents it from working. Considering that it's been there for about two years, it seems unlikely that this has been built since that found its way in.

I fixed that, but the next problem is that, when I follow the above-mentioned guide, and try to run make build-plugin, I get the following:

jack-XPS-13-7390:~/git/ingress-nginx Jack Lund@main M:4 % export GO111MODULE=on
jack-XPS-13-7390:~/git/ingress-nginx Jack Lund@main M:4 % make build-plugin    
no Go files in /go/src/k8s.io/ingress-nginx
malformed import path "-trimpath": leading dash
malformed import path "-ldflags=-buildid= -w -s": leading dash
malformed import path "-X": leading dash
malformed import path "k8s.io/ingress-nginx/version.RELEASE=v1.0.0": invalid char '='
malformed import path "k8s.io/ingress-nginx/version.COMMIT=git-0dbaadf60": invalid char '='
package k8s.io/ingress-nginx/[email protected]:jacklund/ingress-nginx.git: can only use path@version syntax with 'go get' and 'go install' in module-aware mode
malformed import path "-o": leading dash
package cmd/plugin/release/kubectl-ingress_nginx is not in GOROOT (/usr/local/go/src/cmd/plugin/release/kubectl-ingress_nginx)
make: *** [Makefile:91: build-plugin] Error 1

I'm guessing that I'm missing something here that should be obvious, but I'm not sure what it would be.

Any help would be appreciated

@iamNoah1
Copy link
Contributor

/triage accepted
/priority backlog
/help

@k8s-ci-robot
Copy link
Contributor

@iamNoah1:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/priority backlog
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 12, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2022
@crinjes
Copy link

crinjes commented Feb 23, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2022
@iamNoah1
Copy link
Contributor

@jacklund somehow your message got lost in the chatter. Are you still willing to give it a try? Best advice is to join the ingress-nginx-dev and maybe join the bi-weekly meetings to ask for help.

@kundan2707
Copy link
Contributor

@iamNoah1 if no one is working on it i want to work on this .

@iamNoah1
Copy link
Contributor

Go for it

/assign @kundan2707

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 12, 2022
@kundan2707
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 28, 2022
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests