Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial report type #519

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix initial report type #519

merged 2 commits into from
Jun 26, 2024

Conversation

bamx23
Copy link
Collaborator

@bamx23 bamx23 commented Jun 26, 2024

Many unit-tests, no integration tests.
Previously #516 has broken the core API for reports sending. This is a fix.

Copy link
Collaborator

@GLinnik21 GLinnik21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the only integration test is in OOM monitor tests. Anyway, fix the typo and we're good to go!

KSCrash.shared().sendAllReports()
KSCrash.shared().sendAllReports { reports, isSuccess, error in
if isSuccess, let reports {
print("Logged \(reports.count) reoprts")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@GLinnik21 GLinnik21 merged commit 183243f into master Jun 26, 2024
25 checks passed
@GLinnik21 GLinnik21 deleted the fix-reports branch June 26, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants