Allow custom base override #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
reviewed
Jun 23, 2024
| * @note This method SHOULD be called before any use of `sharedInstance` method. | ||
| * Any call of this method after that is ignored. | ||
| */ | ||
| (void) setBasePath:(nullable NSString*) basePath; |
There was a problem hiding this comment.
This means that user would try to change it after the installation. Maybe better move it to KSCrashConfiguration as a compulsory init parameter?
There was a problem hiding this comment.
Configuration only provided to install. And I can use KSCrash instance without calling install (e.g. to send reports).
There was a problem hiding this comment.
The dependency on the sharedInstance method call to determine whether the base path can be changed creates non-obvious behavior. It's not immediately clear to developers when they can or cannot change the base path. But I don't see a better solution without creating a separate instance of KSCrash.
bamx23
force-pushed
the
add-custom-base-path-api
branch
from
0342598
to
1cdd546
Compare
GLinnik21
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes constroctors of
KSCrashclass, but allows setting a custom base path via a helper static method.As there are cases when shared instance of
KSCrashis used from inside of the library code we need to make sure that base path is consistent.Also, in general,
KSCrashis intended to be a singletone as the most of C API under the hood operates with global state. Multiple instances of KSCrash was never supported.