Add new samples #511
Add new samples #511
Conversation
|
|
||
| public class RecordingSample { | ||
| public static func simpleInstall() { | ||
| let config = KSCrashConfiguration() |
There was a problem hiding this comment.
What do you think? Does this name look ok in swift?
There was a problem hiding this comment.
Not sure. I would want to have just install if I don't care about config.
And also maybe having a way to inline config creation like:
KSCrash.shared().install(with: .init(monitors: [.asyncSafe]))But this last idea is the one I'm not sure about here.
While I think it can be possible, I would still have this entry point file to be separate for each of the samples. The most of the code is intended to go to that common SwiftUI library. But it's already not the same for macOS as we need to override the app delegate. 2 files per sample that you don't need to touch in most of the cases – sounds good to me. |
This PR adds a minimal sample for each of the supported platforms.
Supporting Xcode projects for each of the platform is a bit painful, so here I'm adding a dependency on Tuist for projects generation.
The common part of the samples is managed using SPM to ensure that integration of KSCrash into samples is as close as possible to real use of SPM. Sorry, no CocoaPods (not sorry).
As a follow up, we can create a set of build jobs to ensure there's no breaking API changes (after most of the APIs are used in these samples).