FIX: Resolve stack overflow caused by insufficient disk space. #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
requested changes
May 17, 2024
|
@GLinnik21 writer->buffer is a variable allocated on the stack, so it causes a stack overflow. |
|
Let’s add some unit tests. If it’s too complex without mocks or dependency injection, we can merge it as is. |
|
Sorry, writing unit tests is quite challenging for me.😞 |
bamx23
pushed a commit
that referenced
this pull request
May 24, 2024
* FIX: Resolve stack overflow caused by insufficient disk space. * modify the format * FIX: Resolve stack overflow caused by insufficient disk space. * modify the format --------- Co-authored-by: yuencong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the disk space is insufficient, the ksfu_flushBufferedWriter method will return false, and the value of writer->position will not be set to 0. Continuing to write values to writer->buffer at this point will result in a stack overflow.