Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding project id per configuration entry #62

Closed
rogierknoester opened this issue Jul 5, 2024 · 2 comments · Fixed by #63
Closed

Overriding project id per configuration entry #62

rogierknoester opened this issue Jul 5, 2024 · 2 comments · Fixed by #63
Assignees

Comments

@rogierknoester
Copy link
Contributor

Describe the feature you would like to see

Hi,

we're starting to use your bundle (and great lib) for push notifications. In our situation our backend service lives in project A and the apps live in project B. We run within GCP so our workloads have a service account for project A available. This service account has been given the roles for FCM in project B. It can send notifications when testing locally (with SA key file for project A but changing the project to B manually in the file). However, when we deploy the service account that is automatically provided will resolve to project A, not B. Meaning it cannot send messages. Ideally, it would be possible to simply override with an extra config entry field:

kreait_firebase:
    projects:
        some-project-name:
            project_id: project-b

In the base library this seems possible by calling ::withProjectId(...), so right now I am leaning to use the library directly and write a new factory. But of course, being able to do this with the bundle is more appropriate.

Is there something I am missing or is it indeed a usecase that is not supported yet? If it is not supported would a PR be welcome?

@jeromegamez
Copy link
Member

No, I think you are describing it correctly, this currently isn't possible (and to be honest, I didn't know it was possible to send messages from Project A to devices in Project B, that's nice!)

A PR would be great, but perhaps I can find some time on the weekend - let's see who is faster 😅

@rogierknoester
Copy link
Contributor Author

let's see who is faster 😅

I took the liberty to write it already, it's not much but I think it does the job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants