Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use varname to resolve variable names #54

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Use varname to resolve variable names #54

merged 2 commits into from
Jan 25, 2021

Conversation

kotarot
Copy link
Owner

@kotarot kotarot commented Jan 25, 2021

We don't need to give var name any longer.

@codecov
Copy link

codecov bot commented Jan 25, 2021 •
edited
Loading

Codecov Report

Merging #54 (b7e66c3) into main (df5686d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #54    /-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         1419      1423     4     
=========================================
  Hits          1419      1423     4
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sawatabi/base_mixin.py 100.00% <100.00%> (ø)
sawatabi/model/constraint/abstract_constraint.py 100.00% <100.00%> (ø)
sawatabi/model/constraint/n_hot_constraint.py 100.00% <100.00%> (ø)
sawatabi/model/logical_model.py 100.00% <100.00%> (ø)
sawatabi/solver/dwave_solver.py 100.00% <100.00%> (ø)
sawatabi/solver/local_solver.py 100.00% <100.00%> (ø)
sawatabi/solver/optigan_solver.py 100.00% <100.00%> (ø)
sawatabi/solver/sawatabi_solver.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df5686d...b7e66c3. Read the comment docs.

@kotarot kotarot merged commit 5ec8d6b into main Jan 25, 2021
@kotarot kotarot deleted the varname branch January 25, 2021 15:51
@kotarot
Copy link
Owner Author

kotarot commented Jan 28, 2021

Will revert this change, since it sometimes does not work in the package.

kotarot added a commit that referenced this pull request Jan 28, 2021
@kotarot
Revert "Use varname to resolve variable names (#54)"
00641c6 
This reverts commit 5ec8d6b.
@kotarot kotarot mentioned this pull request Jan 28, 2021
Merged
kotarot added a commit that referenced this pull request Jan 28, 2021
@kotarot
Revert "Use varname to resolve variable names" (#57)
4d0fa5d 
* Revert "Use varname to resolve variable names (#54)"

This reverts commit 5ec8d6b.

* Fix newly added _check_argument_type

* Sort install_requires
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kotarot