Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not index non-active (which means its value is 0) variables #51

Merged
merged 7 commits into from
Jan 25, 2021

Conversation

kotarot
Copy link
Owner

@kotarot kotarot commented Jan 25, 2021

If values of some variables are 0, indices of physical model is weird.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #51 (22a5abe) into main (fb4aaf3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #51    /-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         1408      1413     5     
=========================================
  Hits          1408      1413     5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sawatabi/model/logical_model.py 100.00% <100.00%> (ø)
sawatabi/model/physical_model.py 100.00% <100.00%> (ø)
sawatabi/solver/sawatabi_solver.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4aaf3...22a5abe. Read the comment docs.

@kotarot kotarot merged commit b5ec906 into main Jan 25, 2021
@kotarot kotarot deleted the non-active-var-index branch January 25, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant