-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for polygon/linestring in results #823
base: master
Are you sure you want to change the base?
Conversation
I haven't done a full review yet but I do have some general thoughts on the implementation:
Two other considerations come in mind but they are easily deferred to follow-up PRs:
|
Thanks. I will update the PR with the changes in this file soon. One question though about the 'Elasticsearch is on it's way out': I've been planning to update the Elastic client to the Java API so you can use an existing Elasticsearch cluster instead of the internal one (newer versions of Elasticsearch don't support the Transport client). Is my new PR still a good idea?
Will take this along as well.
Agreed
OK. I will make the default to return the polygon when it's available in the index. The option 'polygon=false' will return the centroid instead.
Will do.
I have to look into this issue.
I will look into this. |
We'll drop ES support completely and go with OpenSearch. Note that the OS version already supports an external OpenSearch cluster. The support is just somewhat rudimentary and HTTP-only. |
Would this PR return a Multipolygon in case for queries like "hamburg"? See the nominatim response. Currently photon returns a slightly confusing, but correct extent as only a single extent is allowed https://photon.komoot.io/api/?q=hamburg ... or maybe we add a new field |
At the moment, photon only returns the point of a location, and not the polygon (see #259). This PR will add the option to add the polygon (i.e. geometry) to the Elasticsearch Index and a API parameter
polygon
to return said polygon. If no polygon exists, the point is returned.WARNING: This will increase the Elasticsearch Index size! (~575GB for a Planet import).
To enable: add the command line argument
-use-geometry-column
whilst importing and add&polygon=true
to the API call.