Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Result instead of IResult #33

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Return Result instead of IResult #33

merged 3 commits into from
Jul 19, 2022

Conversation

DrLuke
Copy link
Contributor

@DrLuke DrLuke commented Jul 3, 2022

Previously the decoder methods returned an IResult. That required importing nom::Err into your project and dealing with the nom error, which was unnecessary.

Closes #30

klingtnet
klingtnet requested changes Jul 10, 2022
View reviewed changes
src/decoder.rs Outdated Show resolved Hide resolved
src/decoder.rs Outdated Show resolved Hide resolved
@klingtnet klingtnet merged commit f858b93 into klingtnet:master Jul 19, 2022
@klingtnet
Copy link
Owner

Great work again, thank you very much for your contribution @DrLuke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klingtnet klingtnet klingtnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decoder methods wrap OscError in nom Err enum
2 participants
@DrLuke @klingtnet