Added data-tag attribute to passageCard #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klembot
requested changes
Feb 5, 2024
3 tasks
|
@rubynguyen1510 looks good now, but one last question before I merge: any reason you used |
|
Thanks for your feedback! We overlooked the plural naming convention. Just fixed it! |
klembot
reviewed
Feb 10, 2024
|
@rubynguyen1510 almost there, I think! |
klembot
approved these changes
Feb 11, 2024
|
Looks good--thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Fixed
#1438
Testing
In the development of our test to validate the data-tags attribute on the passage card, we evaluated two potential selection methods. They were 'getByTestId' and 'getByText'.
getByTestID
const passageElement = screen.getByTestId('passage-card');getByText
const passageElement = screen.getByText(passage.name).closest('.passage-card');We chose getByTestId over getByText because it is more reliable, and efficient and could be used to specifically target the passage card element.
Test Results
Credit
[X] We would like to be credited in the application as Siham Argaw and Ngoc Nguyen.
Presubmission Checklist
[X] We have read this project's CONTRIBUTING file, and this PR follows the criteria laid out there.
[X] This contribution was created by us and we have the right to submit it under the GPL v3 license. (This is not a rights assignment.)
[X] We have read and agree to abide by this project's Code of Conduct.