Move kivy.core.audio to kivy.core.audio_output, reserve kivy.core.audio_input for future use #8579 #8721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
|
Hi @pedroarduini , Looks like you added unrelated files in your commit (Cython-generated files, build script), |
|
Hey, thanks for noting. Cleaned up the installation file and ran "make cleanup" to clean compiled files. Please let me know if there's anything else to clean |
…ster_libs audio_output call Change test function calls
misl6
force-pushed
the
move-audio-core-8579
branch
from
eda2859
to
d9bd6d7
Compare
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed audio module to audio_output refactoring all calls to the previous names.
Also, as demanded, reserved an audio_input module for future development.