Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock gl backend egl context should not be managed by sdl #8694

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Apr 21, 2024

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

mock gl backend should be treated as angle, as sdl should not manage the egl context.

Previously did not failed as sdl have been built with OpenGL support, but since the introduction of the ANGLE EGL provider sdl is being built without OpenGL support enabled.

During wheel tests, performed with KIVY_GL_BACKEND=mock, the pipeline is failing as sdl is trying to create a window with OpenGL support, even if we opted out.

@misl6 misl6 added Component: graphics kivy/graphics Component: core-providers kivy/core and removed Component: graphics kivy/graphics labels Apr 21, 2024
@misl6 misl6 added this to the 3.0.0 milestone Apr 21, 2024
@misl6 misl6 changed the title mock gl backend egl context should not be managed by sdl mock gl backend egl context should not be managed by sdl [build wheel] Apr 21, 2024
@misl6 misl6 force-pushed the fix/mock-gl-backend-should-not-require-opengl-sdl2-support branch from 7cbf7a9 to b8fcf31 Compare April 21, 2024 15:32
@misl6 misl6 force-pushed the fix/mock-gl-backend-should-not-require-opengl-sdl2-support branch from b8fcf31 to 9f598bb Compare April 21, 2024 15:32
@misl6 misl6 changed the title mock gl backend egl context should not be managed by sdl [build wheel] mock gl backend egl context should not be managed by sdl Apr 22, 2024
@misl6 misl6 merged commit 1f7f5b5 into kivy:master Apr 22, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant