Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added property for mouse draggable tab scrollbar to TabbedPanel #8144

Merged
merged 3 commits into from
Mar 11, 2023
Merged

Added property for mouse draggable tab scrollbar to TabbedPanel #8144

merged 3 commits into from
Mar 11, 2023

Conversation

djogy
Copy link
Contributor

@djogy djogy commented Feb 25, 2023 •
edited by akshayaurora
Loading

Added bar_width and scroll_type properties for ScrollView to enable mouse control of tab scrollbars.

Example:

tp = TabbedPanel(bar_width='10dp', scroll_type=['content', 'bars'])

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@welcome
Copy link

welcome bot commented Feb 25, 2023

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

@akshayaurora akshayaurora changed the title Added property for mouse draggable tab scrollbar Added property for mouse draggable tab scrollbar to TabbedPanel Feb 26, 2023
@akshayaurora akshayaurora added Component: Widgets kivy/uix, style.kv Type: Feature Issue is a feature request labels Feb 26, 2023
akshayaurora
akshayaurora requested changes Feb 26, 2023
View reviewed changes
kivy/uix/tabbedpanel.py
bar_width = NumericProperty('2dp')
'''Width of the horizontal scroll bar. The width is interpreted
as a height for the horizontal bar.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add .. versionadded tags here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing.

Is the version 2.2.0 OK?

.. versionadded:: 2.2.0

kivy/uix/tabbedpanel.py

'''Sets the type of scrolling to use for the content of the scrollview.
Available options are: ['content'], ['bars'], ['bars', 'content'].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, needs version added.

@djogy
Copy link
Contributor Author

djogy commented Mar 10, 2023

I added the version tags.
Please tell me if I make a mistake.

@akshayaurora akshayaurora added the Notes: Release-highlight Highlight this PR in the release notes. label Mar 10, 2023
@akshayaurora akshayaurora added this to the 2.2.0 milestone Mar 10, 2023
@misl6 misl6 merged commit 4388451 into kivy:master Mar 11, 2023
@welcome
Copy link

welcome bot commented Mar 11, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@djogy djogy deleted the draggable_tab_scroll branch March 11, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayaurora akshayaurora akshayaurora approved these changes

Assignees
No one assigned
Labels
Component: Widgets kivy/uix, style.kv Notes: Release-highlight Highlight this PR in the release notes. Type: Feature Issue is a feature request
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djogy @akshayaurora @misl6