Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Allows to hide the taskbar icon #8142

Merged
merged 5 commits into from
Apr 1, 2023
Merged

Conversation

DexerBR
Copy link
Contributor

@DexerBR DexerBR commented Feb 22, 2023

This PR introduces the possibility to hide the taskbar application icon.

Options:

  • 0 → The icon will be hidden in the taskbar.
  • 1 → default - The icon will be shown on the taskbar.

Test code:

from kivy.config import Config
Config.set("graphics", "show_taskbar_icon", 0)

from kivy.app import App
from kivy.uix.button import Button


class TestApp(App):

    def build(self):
        return Button(text="Hello World")

if __name__ == "__main__":
    TestApp().run()

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

kivy/config.py Outdated Show resolved Hide resolved
@DexerBR DexerBR requested a review from misl6 February 25, 2023 14:22
@misl6 misl6 added this to the 2.2.0 milestone Mar 19, 2023
kivy/core/window/window_sdl2.py Outdated Show resolved Hide resolved
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DexerBR !

Seems there's a typo. I've left a suggestion block.

kivy/config.py Outdated Show resolved Hide resolved
@DexerBR DexerBR requested a review from misl6 March 26, 2023 13:52
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit cf4f5b8 into kivy:master Apr 1, 2023
@DexerBR DexerBR deleted the taskbar_icon branch April 1, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants