Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera: Fixes crash during camera configuration #7071

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Camera: Fixes crash during camera configuration #7071

merged 1 commit into from
Sep 27, 2020

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Sep 9, 2020

This PR fixes a potential runtime crash during camera re-configuration where the texture it's still None.

tshirtman
tshirtman approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@tshirtman tshirtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tshirtman tshirtman merged commit 77ad019 into kivy:master Sep 27, 2020
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title Fixes crash during camera configuration Camera: Fixes crash during camera configuration Dec 8, 2020
@matham matham mentioned this pull request Dec 10, 2020
Merged
@wolfmanjm wolfmanjm mentioned this pull request Dec 11, 2020
Closed
@matham
Copy link
Member

matham commented Dec 11, 2020

This causes #7259. I believe the issue is that when on_load is dispatched, we may not have the final texture, and the real texture never gets set. So #7049 is a better fix as it only sets the texture when the texture is updated.

@matham matham mentioned this pull request Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshirtman tshirtman tshirtman approved these changes

Assignees
No one assigned
Labels
Component: core-providers kivy/core
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@misl6 @matham @tshirtman