Image: Remove gpl gif implementation #6721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid depending on pillow just for our loading animation, created a zip alternative, and replaced it for usage in all places.
|
Is this the only implementation for gif (other than ffpyplayer)? If so, don't we need to go through a deprecation cycle? |
|
We also have the Pillow implementation, this is the only one we have without third party dependencies though.
If we think we need to support gif out of the box, we should either make a dependency like Pillow or ffpyplayer mandatory, or shop/build a better implementation to include in kivy. |
matham
approved these changes
Feb 14, 2020
matham
changed the title
matham
added
Component: core-providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid depending on pillow just for our loading animation, created a
zip alternative, and replaced it for usage in all places.